venkateshwaracholan opened a new pull request, #4840: URL: https://github.com/apache/polaris/pull/4840
## Summary This PR removes a few outdated commented-out lines from the `createS3Client()` implementations in both `MinioContainer` and `RustfsContainer`. The comments appear to be leftovers from earlier Nessie-related S3 client configuration code that is no longer used. Because they do not reflect the current implementation, they can create confusion for contributors reading the code and make the methods appear more complex than they actually are. By removing these obsolete comments, the code becomes easier to read and maintain while keeping the implementation focused on the active logic. ## Changes * Removed obsolete commented-out S3 client configuration code from `MinioContainer#createS3Client()`. * Removed the same obsolete comments from `RustfsContainer#createS3Client()`. * No executable code was changed. * No functional or behavioral changes were introduced. ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #4839 - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
