dimas-b commented on code in PR #4825:
URL: https://github.com/apache/polaris/pull/4825#discussion_r3443646851
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/PolarisResolutionManifest.java:
##########
@@ -272,7 +272,10 @@ public Set<PolarisBaseEntity>
getAllActivatedPrincipalRoleEntities() {
}
public PolarisResolvedPathWrapper getResolvedRootContainerEntityAsPath() {
- return new
PolarisResolvedPathWrapper(List.of(getResolvedRootContainerEntity()));
+ ResolvedPolarisEntity root = getResolvedRootContainerEntity();
+ return root == null
+ ? new PolarisResolvedPathWrapper(List.of())
Review Comment:
My take is that since there is no real runtime bug, I'd prefer a big
clean-up / refactoring addressing value availability / nullability concerns in
this code from a general end-to-end perspective.... but this is a rather big
effort - best to discuss on `dev`.
Small incremental changes that tackle null values in narrow sub-cases
introduce risk of unknown / hard-to-foresee regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
