sungwy commented on code in PR #4356:
URL: https://github.com/apache/polaris/pull/4356#discussion_r3456663914
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -253,7 +269,15 @@ private PolarisResolutionManifest
authorizeBasicTopLevelEntityOperationOrThrow(
@Nullable String referenceCatalogName) {
PolarisResolutionManifest resolutionManifest =
newResolutionManifest(referenceCatalogName);
resolutionManifest.addTopLevelName(topLevelEntityName, entityType, false
/* isOptional */);
- ResolverStatus status = resolutionManifest.resolveAll();
+ authorizationState.setResolutionManifest(resolutionManifest);
+ authorizer.resolveAuthorizationInputs(
+ authorizationState,
+ new AuthorizationRequest(
+ polarisPrincipal,
+ List.of(
+ new SingleTargetAuthorizationIntent(
+ op, PolarisSecurable.of(new PathSegment(entityType,
topLevelEntityName))))));
+ ResolverStatus status = resolutionManifest.getPrimaryResolverStatus();
Review Comment:
That's a good call out. I've changed the public method to
`getPrimaryResolverStatusOrThrow()` which throws if the
`PolarisResolutionManifest` had not yet resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
