hkwi commented on PR #4836: URL: https://github.com/apache/polaris/pull/4836#issuecomment-4794293572
Addressed the latest review feedback in `25f9c497`: - Preallocated OpenTelemetry `AttributeKey` instances and cached the `PolarisOtelAttribute` values array. - Emit `otel.*` log attributes only when the metadata can be attached as a valid OpenTelemetry span context. - Added sad-path context tests for empty context, short `trace_flags`, and malformed trace IDs. - Normalized `polaris.grant.resource.type` through `toString()` so it matches the JSON `type` value. - Strengthened grant JSON assertions and added a record-count assertion helper before reading captured records. - Moved namespace/name identifier derivation into a shared helper and added coverage for the explicit `TABLE_IDENTIFIER` guard. - Changed attribute serialization failure logging from `DEBUG` to `WARN`. Validation: - `./gradlew :polaris-runtime-service:spotlessApply :polaris-runtime-service:test --tests org.apache.polaris.service.events.listeners.opentelemetry.OpenTelemetryEventListenerTest --tests org.apache.polaris.service.events.listeners.PolarisPersistenceEventListenerTest` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
