dimas-b commented on code in PR #4816:
URL: https://github.com/apache/polaris/pull/4816#discussion_r3493143322
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -1534,22 +1436,17 @@ public ConfigResponse getConfig() {
Map<String, String> properties =
PolarisEntity.of(resolvedReferenceCatalog.getEntity()).getPropertiesAsMap();
+ String prefix = prefixParser().catalogNameToPrefix(catalogName());
return ConfigResponse.builder()
.withDefaults(properties) // catalog properties are defaults
- .withOverrides(
- ImmutableMap.of(
- "prefix",
- prefixParser().catalogNameToPrefix(catalogName()),
- // Polaris does not handle custom namespace separators;
- // always communicate the default namespace separator to
clients.
- RESTCatalogProperties.NAMESPACE_SEPARATOR,
- NamespaceUtils.DEFAULT_NAMESPACE_SEPARATOR_ENCODED))
+ .withOverrides(ImmutableMap.of("prefix", prefix))
.withEndpoints(
ImmutableList.<Endpoint>builder()
.addAll(DEFAULT_ENDPOINTS)
.addAll(VIEW_ENDPOINTS)
.addAll(PolarisEndpoints.getSupportedGenericTableEndpoints(realmConfig()))
.addAll(PolarisEndpoints.getSupportedPolicyEndpoints(realmConfig()))
+
.addAll(PolarisEndpoints.getSupportedSemanticModelEndpoints(realmConfig()))
Review Comment:
This comment thread was initially about the very presence of OSI endpoints
in the IRC config response. This has been discussed on `dev` and I think we can
consider this comment thread resolved.
https://lists.apache.org/thread/15g7mbfs74fv1z41q2s7f9xtq45xqyov
I opened a fresh comment about the pluggability aspect of these endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
