Copilot commented on code in PR #4942:
URL: https://github.com/apache/polaris/pull/4942#discussion_r3499658255
##########
extensions/auth/ranger/build.gradle.kts:
##########
@@ -69,7 +69,9 @@ testing {
implementation(platform(libs.quarkus.bom))
implementation("io.rest-assured:rest-assured")
implementation(project(":polaris-tests"))
- implementation(project(":polaris-runtime-test-common"))
+ implementation(project(":polaris-runtime-test-common")) {
+ exclude(group = "org.jboss.slf4j", module = "slf4j-jboss-logmanager")
+ }
Review Comment:
The PR title implies this exclusion should be applied broadly to non-Quarkus
test classpaths, but only two modules were updated. Other non-Quarkus modules
still depend on :polaris-runtime-test-common without excluding the JBoss SLF4J
provider (e.g. persistence/relational-jdbc, integration-tests, spark plugin
test suites). Because the polaris-java convention adds Logback to test suites
for non-Quarkus projects, those modules will still end up with multiple SLF4J
providers unless they also exclude org.jboss.slf4j:slf4j-jboss-logmanager (or
the exclusion is centralized in shared Gradle logic).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]