dimas-b commented on code in PR #4936:
URL: https://github.com/apache/polaris/pull/4936#discussion_r3503350740


##########
client/python/tests/test_polaris_cli.py:
##########
@@ -144,7 +142,9 @@ def test_enable_api_request_logging_logs_requests(
 
         mock_original_urlopen.assert_called_once()
         output = mock_stderr.getvalue()
-        self.assertIn("Request: GET 
http://localhost:8080/api/management/v1/catalogs";, output)
+        self.assertIn(
+            "Request: GET http://localhost:8080/api/management/v1/catalogs";, 
output

Review Comment:
   From my personal POV, it's preferable to isolate pure formatting changes 
from feature changes.
   
   However, I'm probably going to be away for a few days 
:slightly_smiling_face: Please consider my comments non-blocking and follow 
@MonkeyCanCode 's direction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to