dimas-b commented on code in PR #4926: URL: https://github.com/apache/polaris/pull/4926#discussion_r3506467276
########## polaris-core/src/main/java/org/apache/polaris/core/rest/CatalogConfigEndpointContributor.java: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.rest; + +import java.util.Set; +import org.apache.iceberg.rest.Endpoint; + +/** Contributes endpoints advertised in catalog configuration responses. */ +@FunctionalInterface +public interface CatalogConfigEndpointContributor { + Set<Endpoint> endpoints(); Review Comment: Putting this interface into `runtime/service` is preferable to putting it into `polaris-core` from my POV :slightly_smiling_face: A downside is that the new Open Lineage code (and others) will probably want to contribute endpoints. It will have to depend on `runtime/service`. However, it will not need anything from `runtime/service` but this interface. In that light, I think adding a `runtime/service-spi` module is cleaner and simpler to refactor later (it's always easier to deal with several detached module than with tangled code in one module). I know that `polaris-core` is imported pretty much everywhere, but I do not think it is a good reason to keep all SPI classes there. Unless an interface is actually called from `polaris-core`, it is not conceptually a "core SPI". I believe using separate module separated by purpose / feature is easier to reason about and maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
