flyrain commented on code in PR #4831: URL: https://github.com/apache/polaris/pull/4831#discussion_r3502472661
########## polaris-core/src/main/java/org/apache/polaris/core/auth/VisibilityFilterRequest.java: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import java.util.List; +import org.jspecify.annotations.NonNull; + +/** Carries the context used to filter LIST-operation candidates by visibility. */ +public record VisibilityFilterRequest( + @NonNull PolarisAuthorizableOperation listOperation, Review Comment: `container` is `@NonNull PolarisSecurable`, but `PolarisSecurable.validate()` forbids ROOT segments (PolarisSecurable.java:81) and requires a top-level start (:77) , so there's no way to represent the root container that `LIST_CATALOGS` needs, even though the flag description names `listCatalogs`. I think this is another reason to reuse the existing method `authorize()` and expand on it. ########## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizer.java: ########## @@ -80,4 +80,19 @@ void authorizeOrThrow( @NonNull PolarisAuthorizableOperation authzOp, @Nullable List<PolarisResolvedPathWrapper> targets, @Nullable List<PolarisResolvedPathWrapper> secondaries); + + /** + * Filters a candidate list of securables to only those the principal is authorized to see. + * + * <p>The default implementation returns all candidates unchanged, preserving backward + * compatibility for authorizers that do not implement visibility filtering. + * + * <p>If filtering encounters an error, implementations should throw rather than fall back to + * returning unfiltered results. + */ + @NonNull + default List<PolarisSecurable> filterByVisibility( + @NonNull AuthorizationState authzState, @NonNull VisibilityFilterRequest request) { Review Comment: Agreed with @dimas-b here. Reusing the existing `authorize()` avoids concept-level duplication. To achieve that, we also need some changes in `AuthorizationDecision` so that it can return the decision for a list of securables. Here is the general process: 1. Authorize the list operation on the container. 2. Get a list of securables under the container. 3. Bulk authorize a list of securables under that container, returning the decision on each securable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
