jbonofre commented on code in PR #4983:
URL: https://github.com/apache/polaris/pull/4983#discussion_r3531879646
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -508,8 +508,12 @@ public static void enforceFeatureEnabledOrThrow(
public static final FeatureConfiguration<Boolean> ENABLE_SEMANTIC_MODELS =
PolarisConfiguration.<Boolean>builder()
.key("ENABLE_SEMANTIC_MODELS")
- .description("If true, the semantic-model (OSI) endpoints are
enabled")
- .defaultValue(false) // keep it to false until the implementation is
done
+ .description(
+ "If true, the semantic-model (OSI) endpoints are enabled. This
is a beta feature: "
Review Comment:
```suggestion
"If true, the semantic-model (Apache Ossie) endpoints are
enabled. This is a beta feature: "
```
##########
site/content/in-dev/unreleased/configuration/config-sections/flags-polaris_features.md:
##########
@@ -309,7 +309,7 @@ If true, the policy-store endpoints are enabled
##### `polaris.features."ENABLE_SEMANTIC_MODELS"`
-If true, the semantic-model (OSI) endpoints are enabled
+If true, the semantic-model (OSI) endpoints are enabled. This is a beta
feature: the API is under active development and may change in a
backward-incompatible way. It is disabled by default; enable it with caution
and report any issues encountered.
Review Comment:
```suggestion
If true, the semantic-model (Apache Ossie) endpoints are enabled. This is a
beta feature: the API is under active development and may change in a
backward-incompatible way. It is disabled by default; enable it with caution
and report any issues encountered.
```
##########
spec/polaris-catalog-apis/semantic-models-api.yaml:
##########
@@ -83,6 +86,9 @@ paths:
summary: List semantic models in the given namespace
operationId: listSemanticModels
description: |
+ **Beta:** The semantic-model (OSI) API is under active development and
may change in a
Review Comment:
```suggestion
**Beta:** The semantic-model (Apache Ossie) API is under active
development and may change in a
```
##########
spec/polaris-catalog-apis/semantic-models-api.yaml:
##########
@@ -31,6 +31,9 @@ paths:
summary: Create a semantic model in the given namespace
operationId: createSemanticModel
description: |
+ **Beta:** The semantic-model (OSI) API is under active development and
may change in a
+ backward-incompatible way.
+
Creates a semantic model in the specified namespace.
A semantic model is an Open Semantic Interchange (OSI) document
describing
Review Comment:
```suggestion
A semantic model is an Apache Ossie document describing
```
##########
spec/polaris-catalog-apis/semantic-models-api.yaml:
##########
@@ -31,6 +31,9 @@ paths:
summary: Create a semantic model in the given namespace
operationId: createSemanticModel
description: |
+ **Beta:** The semantic-model (OSI) API is under active development and
may change in a
Review Comment:
```suggestion
**Beta:** The semantic-model (Apache Ossie) API is under active
development and may change in a
```
##########
spec/polaris-catalog-apis/semantic-models-api.yaml:
##########
@@ -122,7 +128,11 @@ paths:
- Semantic Model API
summary: Load a semantic model
operationId: loadSemanticModel
- description: Load a semantic model from the catalog.
+ description: |
+ **Beta:** The semantic-model (OSI) API is under active development and
may change in a
Review Comment:
```suggestion
**Beta:** The semantic-model (Apache Ossie) API is under active
development and may change in a
```
##########
spec/polaris-catalog-apis/semantic-models-api.yaml:
##########
@@ -152,6 +162,9 @@ paths:
summary: Update a semantic model
operationId: updateSemanticModel
description: |
+ **Beta:** The semantic-model (OSI) API is under active development and
may change in a
Review Comment:
```suggestion
**Beta:** The semantic-model (Apache Ossie) API is under active
development and may change in a
```
##########
spec/polaris-catalog-apis/semantic-models-api.yaml:
##########
@@ -205,7 +218,11 @@ paths:
- Semantic Model API
summary: Drop a semantic model from the catalog
operationId: dropSemanticModel
- description: Remove a semantic model from the catalog.
+ description: |
+ **Beta:** The semantic-model (OSI) API is under active development and
may change in a
Review Comment:
```suggestion
**Beta:** The semantic-model (Apache Ossie) API is under active
development and may change in a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
