dimas-b commented on code in PR #4984:
URL: https://github.com/apache/polaris/pull/4984#discussion_r3532429195
##########
runtime/test-common/src/main/java/org/apache/polaris/test/commons/CockroachRelationalJdbcLifeCycleManagement.java:
##########
@@ -22,20 +22,24 @@
import io.quarkus.test.common.DevServicesContext;
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
+import java.util.HashMap;
import java.util.Map;
import org.testcontainers.cockroachdb.CockroachContainer;
public class CockroachRelationalJdbcLifeCycleManagement
implements QuarkusTestResourceLifecycleManager,
DevServicesContext.ContextAware {
public static final String INIT_SCRIPT = "init-script";
+ public static final String POLARIS_MANAGED_DATASOURCE =
"polaris-managed-datasource";
private CockroachContainer cockroach;
private String initScript;
+ private boolean polarisManagedDatasource;
private DevServicesContext context;
@Override
public void init(Map<String, String> initArgs) {
initScript = initArgs.get(INIT_SCRIPT);
+ polarisManagedDatasource =
Boolean.parseBoolean(initArgs.get(POLARIS_MANAGED_DATASOURCE));
Review Comment:
Who controls the value of this variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
