dimas-b commented on code in PR #4975:
URL: https://github.com/apache/polaris/pull/4975#discussion_r3533002385
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergOverlappingTableTest.java:
##########
@@ -727,4 +741,55 @@ void
testParentChildOverlapWithOptimizedSiblingCheck(@TempDir Path tempDir) {
assertThat(createTable(services, derivedLocation + "/child"))
.isEqualTo(Response.Status.FORBIDDEN.getStatusCode());
}
+
+ @Test
+ @DisplayName("Hashed default location encodes non-ASCII identifiers with
UTF-8")
+ void testHashedTableLocationsEncodeNonAsciiIdentifiersAsUtf8(@TempDir Path
tempDir) {
Review Comment:
This is a good test, but it probably does not belong in the "overlapping
table" test class. Why not put it into `LocalIcebergCatalogTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
