iting0321 commented on code in PR #4974:
URL: https://github.com/apache/polaris/pull/4974#discussion_r3543302193
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -687,6 +687,24 @@ private Map<String, SecretReference>
extractSecretReferences(
return secretReferences;
}
+ private void deleteSecretReferencesAfterFailedCatalogCreate(
+ Map<String, SecretReference> secretReferences) {
+ secretReferences
+ .values()
+ .forEach(
+ secretReference -> {
+ try {
+ getUserSecretsManager().deleteSecret(secretReference);
+ } catch (RuntimeException e) {
+ LOGGER
+ .atWarn()
+ .setCause(e)
+ .addKeyValue("secretReference", secretReference.urn())
Review Comment:
Thanks for your feedback! I just updated the message to reference the URN
directly while keeping the structured field for filtering and correlation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
