dimas-b commented on code in PR #4981:
URL: https://github.com/apache/polaris/pull/4981#discussion_r3555993826
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatabaseType.java:
##########
@@ -53,9 +53,9 @@ public String getDisplayName() {
*/
public int getLatestSchemaVersion() {
return switch (this) {
- case POSTGRES -> 4; // PostgreSQL has schemas v1, v2, v3, v4
- case COCKROACHDB -> 4; // CockroachDB schema version kept in sync with
PostgreSQL
- case H2 -> 4; // H2 uses same schemas as PostgreSQL
+ case POSTGRES -> 5; // PostgreSQL has schemas v1, v2, v3, v4, v5
Review Comment:
side note: it is unfortunate that changes to events tables require a schema
version bump that also affects metastore tables 🤷 Would it be nicer to evolve
events schema and metastore scheme separately (not in this PR, but in general)?
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
