flyrain commented on code in PR #4923: URL: https://github.com/apache/polaris/pull/4923#discussion_r3606274063
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -179,6 +179,29 @@ polaris.file-io.type=default # quarkus.otel.logs.enabled=true # quarkus.otel.exporter.otlp.endpoint=http://otlp-collector:4317 +# Kafka event listener settings +# Publishes polaris events to Kafka topic. The key for the Kafka record is +# the event id, a UUID, while the value of the record is a map of key values. +# The keys included in the map depend on the type of event but includes "event_type", +# "table_name", "namespace", "table_identifier", "view_identifier", +# "view_name", "namespace_name", "catalog_name", "realm_id", "principal", +# "activated_roles", "timestamp" (milliseconds from epoch), "request_id" +# and "source" and "destination" for a table rename event. The values are Strings +# except for "timestamp" which is an integer and for "activated_roles" which is +# an array of Strings. +# As the key is a UUID to ensure FIFO order for the Kafka stream a +# single Kafka partition should be used. Review Comment: nit: I'd also put this message in the user faced doc, smallrye-polaris_event_listener_kafka.md. ########## site/content/in-dev/unreleased/configuration/config-sections/smallrye-polaris_event_listener_kafka.md: ########## @@ -0,0 +1,52 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +title: smallrye-polaris_event_listener_kafka Review Comment: Why is `smallrye` part of the title? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
