mattfaltyn opened a new pull request, #5098: URL: https://github.com/apache/polaris/pull/5098
## Summary - Track terminal provisioning failures during `setup apply`. - Preserve best-effort processing so later resources are still attempted. - Exit with the standard CLI error status instead of logging a false success. ## Why `setup apply` catches provisioning exceptions to continue applying the rest of a configuration. Previously, those caught failures were never reflected in the command result, so automation received exit status 0 and a success message even when one or more requested resources were not provisioned. The command now counts those failures and raises a `CliError` after processing the configuration. A regression test verifies both the nonzero result and the best-effort continuation behavior. Fixes #5097 ## Testing - `make client-unit-test` (154 tests and 32 subtests passed) - `PRE_COMMIT_HOME=/tmp/polaris-pre-commit make client-lint` (all hooks passed) - `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH ./gradlew format compileAll` (build successful) ## Checklist - [x] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #5097 - [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [x] ๐ก Added comments for complex logic (no complex logic added) - [x] ๐งพ Updated `CHANGELOG.md` (if needed) - [x] ๐ Updated documentation in `site/content/in-dev/unreleased` (not needed; documented behavior is unchanged) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
