adutra opened a new pull request, #5107: URL: https://github.com/apache/polaris/pull/5107
This change moves `KeycloakContainer` and `KeycloakTestResource` to a dedicated module, following the pattern used for other similar containers. Furthermore, this change removes completely the dependency on `org.keycloak:keycloak-admin-client` and `com.github.dasniko:testcontainers-keycloak`. Removing `org.keycloak:keycloak-admin-client` is justified because this module uses RESTEasy Classic, which Quarkus forbids in tests. This was effectively making it very hard to use Keycloak freely in Polaris tests. The dependency has been replaced with direct HTTP access to Keycloak's admin API. <!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
