dimas-b commented on code in PR #258: URL: https://github.com/apache/polaris-tools/pull/258#discussion_r3630650628
########## polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/planning/plan/SynchronizationReport.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.tools.sync.polaris.planning.plan; + +import java.util.ArrayList; +import java.util.EnumMap; +import java.util.List; +import java.util.Map; + +/** + * Accumulates the outcome of every individual entity sync attempt performed during a run, so that + * a single consolidated summary can be printed at the end instead of relying on interleaved logs. + */ +public class SynchronizationReport { + + private record Failure(EntityType type, String identifier, String message) {} + + private final Map<EntityType, Map<SyncOutcome, Integer>> counts; + + private final List<Failure> failures; + + public SynchronizationReport() { + this.counts = new EnumMap<>(EntityType.class); + for (EntityType type : EntityType.values()) { + Map<SyncOutcome, Integer> outcomeCounts = new EnumMap<>(SyncOutcome.class); + for (SyncOutcome outcome : SyncOutcome.values()) { + outcomeCounts.put(outcome, 0); + } + this.counts.put(type, outcomeCounts); + } + this.failures = new ArrayList<>(); + } + + /** + * Records that an entity was successfully synced. + * + * @param type the category of entity that was synced + * @param outcome the outcome of the sync; must not be {@link SyncOutcome#FAILED} - use {@link + * #recordFailure(EntityType, String, Exception)} for failures + */ + public void recordSuccess(EntityType type, SyncOutcome outcome) { + if (outcome == SyncOutcome.FAILED) { + throw new IllegalArgumentException("Use recordFailure() to record a failed sync."); + } + Map<SyncOutcome, Integer> outcomeCounts = counts.get(type); + outcomeCounts.put(outcome, outcomeCounts.get(outcome) + 1); Review Comment: `Map.compute()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
