huaxingao commented on PR #5122: URL: https://github.com/apache/polaris/pull/5122#issuecomment-5051864693
Per an offline discussion with @flyrain, I dropped the count-based window cap (`MAX_WINDOW_SIZE`) entirely rather than scaling it with the TTL. A fixed count can evict a still-live key, which silently disables idempotency for that key and reintroduces the exact corruption failure mode this feature prevents. We'd rather accept a larger per-entity window under a high write rate than ever drop a key that could still be retried. The window is now bounded solely by expiry (TTL). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
