dimas-b commented on code in PR #5145:
URL: https://github.com/apache/polaris/pull/5145#discussion_r3646845864
##########
runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java:
##########
@@ -177,7 +177,7 @@ static int mapExceptionToResponseCode(RuntimeException rex)
{
case CommitFailedException e -> Status.CONFLICT.getStatusCode();
case UnprocessableEntityException e -> 422;
case CherrypickAncestorCommitException e ->
Status.BAD_REQUEST.getStatusCode();
- case CommitStateUnknownException e -> Status.BAD_REQUEST.getStatusCode();
+ case CommitStateUnknownException e ->
Status.INTERNAL_SERVER_ERROR.getStatusCode();
Review Comment:
I do not see any call paths in that may produce this exception in Polaris
catalogs.
Hive federation may produce it, but it's "off" by default, AFAIK.
Iceberg's `ErrorsHandlers` can produce `CommitStateUnknownException` for 504
responses from Federated REST catalogs, though, but this change remaps it to
500 :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
