mattfaltyn commented on code in PR #5147:
URL: https://github.com/apache/polaris/pull/5147#discussion_r3649778495
##########
client/python/apache_polaris/cli/command/setup.py:
##########
@@ -428,9 +444,7 @@ def _export_namespaces_for_catalog(
catalog_api_client = self._get_catalog_api(api)
catalog_api = IcebergCatalogAPI(catalog_api_client)
try:
- namespaces = sorted(
- catalog_api.list_namespaces(prefix=catalog_name).namespaces
- )
+ namespaces = self._list_namespaces_recursively(catalog_api,
catalog_name)
Review Comment:
Thanks @MonkeyCanCode for the review. I moved the recursive namespace
listing into _export_catalogs, passed the same result to the namespace and
policy exporters, and updated the regression test to verify we only traverse
once per catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
