dimas-b commented on code in PR #5141:
URL: https://github.com/apache/polaris/pull/5141#discussion_r3659141844
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergRestCatalogEventServiceDelegator.java:
##########
@@ -78,7 +79,7 @@ public IcebergRestCatalogEventServiceDelegator(
PolarisEventDispatcher polarisEventDispatcher,
PolarisEventMetadataFactory eventMetadataFactory,
CatalogPrefixParser prefixParser,
- EventAttributeMap eventAttributeMap) {
+ MutableAttributeMap eventAttributeMap) {
Review Comment:
Do we have to declare it as "mutable" here? It looks like access is
read-only in this class.
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ServiceProducers.java:
##########
@@ -495,4 +496,10 @@ public void closeEventListenerExecutor(
managedExecutor.close();
}
}
+
+ @Produces
+ @RequestScoped
+ public MutableAttributeMap eventAttributeMap() {
Review Comment:
Should we add a qualifier to disambiguate? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
