sebbASF commented on pull request #517: URL: https://github.com/apache/incubator-ponymail/pull/517#issuecomment-674584890
If an externally provided list-id is included in the hash, then the has will change if the lid changes. Suppose there is an mbox to be imported. If the individual messages all have list-ids there is no need to specify the lid on the command-line. However if you do provide one (which is advisable in case there are any missing ids), then the hashes will be different. It is vital that the hash depends *only* on the message source (possibly plus a fixed pepper), otherwise reloading the messages may generate a different hash and thus Permalink. As to characters such as @<> being a problem, I agree, but there are other characters that could be used to separate the lid from the hash. For example one could use hash_dev.ponymail.apache.org. I agree that it would be nice to have shorter links, but that should not be at the cost of unstable Permalinks. Now it already looks like it should be possible to use a shorter hash by using base64 so a Permalink of the form: r3358b63557d3a40e179f6ca498a38b9aaf0b2532aba48bfc03c7a1a0@<dev.project.apache.org> might become MTIzNDU2Nzg5MDEyMzQ1Ng_dev.project.apache.org ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
