[GitHub] [incubator-ponymail-foal] sbp opened a new issue, #235: Second argument to can_access_list is accidentally polymorphic in syntax

[GitBox]

sbp opened a new issue, #235:
URL: https://github.com/apache/incubator-ponymail-foal/issues/235

   [In 
server/plugins/messages.py](https://github.com/apache/incubator-ponymail-foal/blob/f23c9ed887db8af2a6b9456f93f5460337369bdb/server/plugins/messages.py#L492-L495)
 the second argument to `plugins.aaa.can_access_list`, `listname`, is a List-Id:
   
   ```python3
       private_lists_accessible = []
       for listname in private_lists_found:
           if plugins.aaa.can_access_list(session, listname):
               private_lists_accessible.append(listname)
   ```
   
   So it would e.g. receive `<example.lists.example.org>`.
   
   But [in 
server/endpoints/preferences.py](https://github.com/apache/incubator-ponymail-foal/blob/f23c9ed887db8af2a6b9456f93f5460337369bdb/server/endpoints/preferences.py#L50-L52)
 the second argument, `ml`, is an email address:
   
   ```python3
               can_access = True
               if entry.get("private", True):
                   can_access = plugins.aaa.can_access_list(session, ml)
   ```
   
   So it would e.g. receive `exam...@lists.example.com`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ponymail.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org