sebbASF commented on issue #266: URL: https://github.com/apache/incubator-ponymail-foal/issues/266#issuecomment-2522937149
The generated URL is presumably intended to be re-usable, as such it should be treated much like a Permalink. Changing how it is generated could affect backwards compatibility. As a work-round, parsing can be enhanced to allow for embedded special characters in values, e.g. rather than use split('=',2), which drops everything after the second '=', one can split at the first '='. To handle embedded '&', one could make use of the fact that the parameter names have a standard form (header_xxx). This is not ideal, but parsing can be adjusted if necessary at a later date without affecting historic URLs, which might not be the case if the URL format is changed. I suppose an alternative might be to change the URL format and add a distinct marker to ensure the code can distinguish it safely, but that would be more work, and would require the code to support both formats in perpetuity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ponymail.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org