GitHub user sebbASF opened an issue:

    https://github.com/apache/incubator-ponymail/issues/292

    Bug: lib/aaa.lua overwrites local customisations on updates

    The lib/aaa.lua module handles all auth.
    The intention is that different sites can define their own auth routines.
    
    At present there are some sample modules under aaa_examples.
    There is also a version in the repo at lib/aaa.lua.
    This means that if the system is installed from source, it will be complete.
    
    However the big disadvantage is that anyone updating their system from the 
repo will have to careful not to overwrite their specific copy.
    
    One way round this would be to remove lib/aaa.lua from the repo and have 
setup.py copy a version from aaa_examples if lib/aaa.lua does not exist.
    
    Another would be to split aaa.lua into two parts:
    - a generic part that has the public API, and delegates to
    - a local part for the specific implementation (e.g. aaa_local)
    
    This would allow common code to be located in aaa.lua, and would allow the 
local part to be independently maintained.
    
    The common part should be able to work on its own if necessary, i.e. just 
return an empty rights list.

----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to