sebbASF opened a new issue #441: Bug: generator should not rely on parsed data, 
in particular dates
URL: https://github.com/apache/incubator-ponymail/issues/441
 
 
   The generator methods currently rely on the parsed message to create the 
hash.
   This is subject to change if the parsing should ever change.
   For example, headers might be unwrapped (or wrapped), and spacing may change 
if the parsing library is updated.
   
   A particular problem is that the date is currently converted into UTC by the 
cluster generator.
   The library does not currently do much validation of the format (for 
example, the following date parses OK: 'Tue, 13 Jul 2004 17:09:03 
-429496729500') 
   
   However if the validation is ever changed, then the date input to the hash 
will change. Given that the actual date is irrelevant to the hash, it should be 
treated the same as any other header, i.e. as textual input only.
   
   If the parsed message is to be used for the hash, then headers need to be 
normalised before use.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to