sebbASF commented on issue #467: setup: move mappings to a separate file URL: https://github.com/apache/incubator-ponymail/pull/467#issuecomment-393665350 Please don't mix changes in a single PR; this makes it harder to review. Also, I'm not convinced that there is a need for the feature. And unfortunately JSON does not support comments, unlike Python. If there is support for the customisation, I would prefer to see it implemented differently, eg by allowing the embedded settings to be overridden by an option that reads a separate file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
