sebbASF commented on issue #489: Errors with Elasticsearch 5.x URL: https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486588658 Good idea to create an iterator. As with any API change, I think it would be better to change the method name. This makes it easier to update the callers (and more obvious when all callers has been found/fixed), and means it is possible to directly test the new behaviour against the old. It's also kinder to 3rd parties who may have written their own scripts using elastic.py. We should deprecate the existing method in favour of the new one.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
