[
https://issues.apache.org/jira/browse/RATIS-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171625#comment-17171625
]
Rui Wang commented on RATIS-1023:
---------------------------------
[~shashikant]
Updated this JIRA description. The context is, while I was reading Ratis code,
I found this TODO which I know how to improve, so I just write code and submit
a patch.
Is this the right pattern to clean up TODO? Should I ask in dev@ firstly for
people's opinions (especially when I am still a newbie to Ratis)?
> During installing snapshot, when snapshot file is corrupted, rename the temp
> snapshot file to .corrupt
> ------------------------------------------------------------------------------------------------------
>
> Key: RATIS-1023
> URL: https://issues.apache.org/jira/browse/RATIS-1023
> Project: Ratis
> Issue Type: Improvement
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Remove the TODO:
> https://github.com/apache/incubator-ratis/blob/c48b0e4507208f0ffa4618efd33bd98a8f9b4649/ratis-server/src/main/java/org/apache/ratis/server/storage/SnapshotManager.java#L118
--
This message was sent by Atlassian Jira
(v8.3.4#803005)