[
https://issues.apache.org/jira/browse/RATIS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze reassigned RATIS-1102:
---------------------------------
Component/s: metrics
Assignee: Siyao Meng
> Fix typo in MetricRegistriesImpl#create warning message
> -------------------------------------------------------
>
> Key: RATIS-1102
> URL: https://issues.apache.org/jira/browse/RATIS-1102
> Project: Ratis
> Issue Type: Bug
> Components: metrics
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The warning message in {{MetricRegistriesImpl#create}} should read
> {{addReport*er*Registration}}. It was missing the "er". It confused me for a
> bit when I'm trying to follow the message.
> {code}
> @Override
> public RatisMetricRegistry create(MetricRegistryInfo info) {
> return registries.put(info, () -> {
> if (reporterRegistrations.isEmpty()) {
> LOG.warn(
> "First MetricRegistry has been created without registering
> reporters. You may need to call" +
> " MetricRegistries.global().addReporterRegistration(...)
> before.");
> }
> RatisMetricRegistry registry = factory.create(info);
> reporterRegistrations.forEach(reg -> reg.accept(registry));
> return registry;
> });
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
