alpapad commented on a change in pull request #411:
URL: https://github.com/apache/incubator-ratis/pull/411#discussion_r567063641
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/storage/SnapshotManager.java
##########
@@ -61,22 +60,23 @@ public void installSnapshot(StateMachine stateMachine,
final long lastIncludedIndex =
snapshotChunkRequest.getTermIndex().getIndex();
final RaftStorageDirectory dir = storage.getStorageDir();
- // create a unique temporary directory
- final File tmpDir = new File(dir.getTmpDir(),
UUID.randomUUID().toString());
+ // create a unique temporary directory based on the request id
+ final File tmpDir = new File(dir.getTmpDir(),
snapshotChunkRequest.getRequestId());
FileUtils.createDirectories(tmpDir);
tmpDir.deleteOnExit();
- LOG.info("Installing snapshot:{}, to tmp dir:{}", request, tmpDir);
Review comment:
This will log the whole chunk.. Lots of bytes..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
