amaliujia commented on a change in pull request #414:
URL: https://github.com/apache/incubator-ratis/pull/414#discussion_r569030579
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/storage/RaftStorageImpl.java
##########
@@ -143,8 +143,10 @@ public RaftConfiguration readRaftConfiguration() {
try (FileInputStream fio = new FileInputStream(confFile)) {
LogEntryProto confProto =
LogEntryProto.newBuilder().mergeFrom(fio).build();
return LogProtoUtils.toRaftConfiguration(confProto);
+ } catch (FileNotFoundException e) {
+
+ return null;
} catch (Exception e) {
- LOG.error("Failed reading configuration from file:" + confFile, e);
return null;
Review comment:
Or actually move the LOG.error to `FileNotFoundException` as that is a
error that has happened thus printing that into log is useful?
I guess to avoid printing every exception is the goal of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
