amaliujia commented on pull request #409: URL: https://github.com/apache/incubator-ratis/pull/409#issuecomment-772241852
> Sorry, I did not make it clear. Your patch is listener reject vote, but I think any candidate should not send RequestVote to listener. Ah the code there is more likely a defensive check. In this PR the candidate actually does not send the RequestVote to listeners. See [here](https://github.com/apache/incubator-ratis/blob/7d0ecb19c692619a992cd7c07adb3d64fbde9ca0/ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java#L276). Basically `getOtherPeers` won't fetch listeners. Also remove that check will change nothing in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
