adoroszlai opened a new pull request #421:
URL: https://github.com/apache/incubator-ratis/pull/421
## What changes were proposed in this pull request?
1. Findbugs 3.0.0 does not work with Maven 3.4+, so it should be upgraded to
3.0.5. But because Findbugs is no longer under development, switch to Spotbugs
(its successor) instead.
2. Fix or suppress warnings that have been introduced while Findbugs was
failing silently. `SuppressFBWarnings` annotation is used instead of XML-based
exclusion (except for protobuf generated source) for the following reasons:
* it can be applied closer to the problem spot, in the same source file
* easier to use
* harder to break accidentally (by renaming, etc.)
https://issues.apache.org/jira/browse/RATIS-1308
## How was this patch tested?
```
$ ./dev-support/checks/findbugs.sh
...
[INFO] BUILD SUCCESS
$ cat target/findbugs/failures
0
```
Findbugs is now successful in CI:
https://github.com/adoroszlai/incubator-ratis/runs/1855897307#step:4:798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
