cnauroth commented on a change in pull request #435:
URL: https://github.com/apache/ratis/pull/435#discussion_r589602710



##########
File path: dev-support/checks/sonar.sh
##########
@@ -20,4 +20,4 @@ if [ ! "$SONAR_TOKEN" ]; then
   echo "SONAR_TOKEN environment variable should be set"
   exit 1
 fi
-mvn -B verify -DskipShade -DskipTests 
org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
-Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache 
-Dsonar.projectKey=apache_incubator-ratis
+mvn -B verify -DskipShade -DskipTests 
org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
-Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache 
-Dsonar.projectKey=apache-ratis

Review comment:
       Thanks for reviewing, @adoroszlai .
   
   I'm not familiar with the Sonar setup.  Does the project key need to be set 
up ahead of time somehow, or would it get activated on the first Sonar run 
under the new key?
   
   Ideally, I'd like to transition to "apache-ratis" and completely remove 
"incubator" for consistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to