softgitron commented on pull request #461: URL: https://github.com/apache/ratis/pull/461#issuecomment-822636980
> @softgitron , thanks a lot for contributing to Ratis! > > > Test case fix is not strictly related to the NPE fixes, but I decided to add it to this pull request. > > Please focus on a single aspect in each pull request. Please feel free to file multiple pull requests if there are different changes. > > A single big pull request is hard to review and easy to make mistakes. > > Indeed, it is not clear what does "Avoid NPE" mean. Which part (which class) of it try to fix? I suggest to start with a single class first. Thanks for a reply @szetszwo! Yea, I admit that this PR ended up being way too fat, but the original fat Jira-ticket tempted me to do it this way. This PR actually fixes 8 different NPE issues in several classes reported by SonarQube and one flake test case. I will close this PR for now and split it into 5-8 separate PRs in the following days. Would you also like to have separate Jira-tickets for all PRs or would sub tasks for RATIS-952 be sufficient (naturally flake test case should have its own Jira)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
