softgitron commented on a change in pull request #465:
URL: https://github.com/apache/ratis/pull/465#discussion_r619638760
##########
File path:
ratis-server/src/test/java/org/apache/ratis/server/impl/RaftReconfigurationBaseTest.java
##########
@@ -339,17 +336,6 @@ void runTestBootstrapReconf(int numNewPeer, boolean
startNewPeer, CLUSTER cluste
final PeerChanges c1 = cluster.addNewPeers(numNewPeer, startNewPeer);
LOG.info("Start changing the configuration: {}",
asList(c1.allPeersInNewConf));
- final AtomicReference<Boolean> success = new AtomicReference<>();
-
- Thread clientThread = new Thread(() -> {
- try {
- RaftClientReply reply =
client.admin().setConfiguration(c1.allPeersInNewConf);
- success.set(reply.isSuccess());
- } catch (IOException ioe) {
- LOG.error("FAILED", ioe);
- }
- });
- clientThread.start();
Review comment:
I see, it took me some time to understand this case correctly, but I
think I got it now. My most recent commit restores execution order, but at the
same time also fixes concurrency problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
