szetszwo commented on a change in pull request #497:
URL: https://github.com/apache/ratis/pull/497#discussion_r701626836
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
##########
@@ -66,6 +68,8 @@
private final GrpcServerMetrics grpcServerMetrics;
+ private final ReadWriteLock lock;
Review comment:
Let's use AutoCloseableReadWriteLock instead of ReentrantReadWriteLock.
Then, we can use try-with-resource to acquire and release the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
