[
https://issues.apache.org/jira/browse/RATIS-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze resolved RATIS-1400.
-------------------------------
Fix Version/s: 2.2.0
Resolution: Fixed
I just have merged the pull request. Thanks, [~jacksonyao]!
> add a separate RWlock for GrpcLogAppender
> -----------------------------------------
>
> Key: RATIS-1400
> URL: https://issues.apache.org/jira/browse/RATIS-1400
> Project: Ratis
> Issue Type: Improvement
> Components: gRPC
> Reporter: Jackson Yao
> Assignee: Jackson Yao
> Priority: Major
> Fix For: 2.2.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> in GrpcLogAppender.java, `synchronized` is used for two purposes:
> 1 protect `wait()`
> 2 protect variables like `pendingRequests`, `pending` , etc.
> i think it is better off add a separate RWLock for the second case ， and keep
> `synchronized` only for wait and notify, thus any slow IO option will not
> block notify
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
