[ 
https://issues.apache.org/jira/browse/RATIS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh H Shukla updated RATIS-1463:
-----------------------------------
    Description: 
There is redundant logging that is done which should be at TRACE level. 
Starting a PR.

 
{quote}{{commit 2684423629cc51a780e74ac71928bda945c863f0}}
{{Author: Ritesh H Shukla <[email protected]>}}
{{Date:   Tue Dec 7 21:37:51 2021 -0800}}{{{}    RATIS-1463 Fix verbose logging 
at INFO level{}}}{{{}diff --git 
a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java 
b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java{}}}
{{index 9777a854..b8d1c8f7 100644}}
{{— 
a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java}}
{{+++ 
b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java}}
{{{}@@ -140,7 +140,7 @@ class FollowerState extends Daemon{}}}{{{}Unknown 
macro: \{            }{}}}{{         }}}
{{       } catch (InterruptedException e) {}} - {{{}       LOG.info("{} was 
interrupted: {}", this, e);{}}}{{{}+        LOG.info("{} was interrupted", 
this);{}}}{{         LOG.trace("TRACE", e);}}{{         
Thread.currentThread().interrupt();}}{{         return;}}{quote}

  was:
There is redundant logging that is done which should be at TRACE level. 
Starting a PR.

 
{quote}commit 2684423629cc51a780e74ac71928bda945c863f0
Author: Ritesh H Shukla <[email protected]>
Date:   Tue Dec 7 21:37:51 2021 -0800

    RATIS-1463 Fix verbose logging at INFO level

diff --git 
a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java 
b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java
index 9777a854..b8d1c8f7 100644
--- a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java
+++ b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java
@@ -140,7 +140,7 @@ class FollowerState extends Daemon {
           }
         }
       } catch (InterruptedException e) {
-        LOG.info("{} was interrupted: {}", this, e);
+        LOG.info("{} was interrupted", this);
         LOG.trace("TRACE", e);
         Thread.currentThread().interrupt();
         return;
{quote}


> Fix redundant verbose logging at INFO level
> -------------------------------------------
>
>                 Key: RATIS-1463
>                 URL: https://issues.apache.org/jira/browse/RATIS-1463
>             Project: Ratis
>          Issue Type: Bug
>          Components: common
>            Reporter: Ritesh H Shukla
>            Priority: Minor
>
> There is redundant logging that is done which should be at TRACE level. 
> Starting a PR.
>  
> {quote}{{commit 2684423629cc51a780e74ac71928bda945c863f0}}
> {{Author: Ritesh H Shukla <[email protected]>}}
> {{Date:   Tue Dec 7 21:37:51 2021 -0800}}{{{}    RATIS-1463 Fix verbose 
> logging at INFO level{}}}{{{}diff --git 
> a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java 
> b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java{}}}
> {{index 9777a854..b8d1c8f7 100644}}
> {{— 
> a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java}}
> {{+++ 
> b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java}}
> {{{}@@ -140,7 +140,7 @@ class FollowerState extends Daemon{}}}{{{}Unknown 
> macro: \{            }{}}}{{         }}}
> {{       } catch (InterruptedException e) {}} - {{{}       LOG.info("{} was 
> interrupted: {}", this, e);{}}}{{{}+        LOG.info("{} was interrupted", 
> this);{}}}{{         LOG.trace("TRACE", e);}}{{         
> Thread.currentThread().interrupt();}}{{         return;}}{quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to