szetszwo commented on a change in pull request #566:
URL: https://github.com/apache/ratis/pull/566#discussion_r770676041



##########
File path: 
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -457,6 +457,18 @@ static void setRetentionFileNum(RaftProperties properties, 
int numSnapshotFilesR
   interface DataStream {
     String PREFIX = RaftServerConfigKeys.PREFIX + ".data-stream";
 
+    String ASYNC_REQUEST_THREAD_POOL_CACHED_KEY = PREFIX + 
".async.request.thread.pool.cached";
+    boolean ASYNC_REQUEST_THREAD_POOL_CACHED_DEFAULT = false;
+
+    static boolean useCachedThreadPool(RaftProperties properties) {
+      return getBoolean(properties::getBoolean, 
ASYNC_REQUEST_THREAD_POOL_CACHED_KEY,
+          ASYNC_REQUEST_THREAD_POOL_CACHED_DEFAULT, getDefaultLog());
+    }
+
+    static void setUseCachedThreadPool(RaftProperties properties, boolean 
useCached) {

Review comment:
       @captainzmc , thanks for the update. We also need to update the getter 
and setter method names. Otherwise, TestConfUtils will fail.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to