szetszwo commented on a change in pull request #568:
URL: https://github.com/apache/ratis/pull/568#discussion_r772952433
##########
File path:
ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -103,18 +106,27 @@ public String toString() {
}
private final DataStreamClientRpc dataStreamClientRpc;
- private final SlidingWindow.Client<DataStreamWindowRequest, DataStreamReply>
slidingWindow;
+
private final Semaphore requestSemaphore;
private final TimeDuration requestTimeout;
private final TimeoutScheduler scheduler = TimeoutScheduler.getInstance();
+ private final ClientId clientId;
+
+ private final ConcurrentMap<ClientInvocationId,
SlidingWindow.Client<DataStreamWindowRequest, DataStreamReply>>
+ slidingWindows = new ConcurrentHashMap<>();
Review comment:
We may move slidingWindow to DataStreamOutputImpl. Then, we don't have
to create this map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]