szetszwo commented on a change in pull request #594:
URL: https://github.com/apache/ratis/pull/594#discussion_r794382481
##########
File path: ratis-client/src/main/java/org/apache/ratis/client/RaftClient.java
##########
@@ -64,6 +65,9 @@
/** Get the {@link SnapshotManagementApi} for the given server. */
SnapshotManagementApi getSnapshotManagementApi(RaftPeerId server);
+ /** Get the {@link SetLeaderElectionApi} for the given server. */
+ SetLeaderElectionApi getSetLeaderElectionApi(RaftPeerId server);
Review comment:
Let's call it LeaderElectionManagementApi.
##########
File path:
ratis-client/src/main/java/org/apache/ratis/client/api/SetLeaderElectionApi.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.ratis.client.api;
+
+import org.apache.ratis.protocol.RaftClientReply;
+
+import java.io.IOException;
+
+/**
+ * An API to support control leader election
+ * such as pause and resume election
+ */
+public interface SetLeaderElectionApi {
+
+ /** pause leader election. */
+ RaftClientReply pause(long timeoutMs) throws IOException;
+
+ /** resume leader election. */
+ RaftClientReply resume(long timeoutMs) throws IOException;
Review comment:
We should not have the timeoutMs parameter since it won't be used in the
server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
