szetszwo commented on pull request #595: URL: https://github.com/apache/ratis/pull/595#issuecomment-1026015215
@adoroszlai , thanks a lot for your comments. > Should ratis-proto/src/main/proto/Hadoop.proto also move? Yes. > There is some Hadoop-specific logic in ratis-resource-bundle/src/main/resources/META-INF/LICENSE.vm. Good catch. We should remove the Hadoop-specific logic. > BUILDING.md mentions the separate (nonexistent) repo ratis-thirdparty-hadoop and that org.apache.hadoop.ipc.protobuf should be shaded. Is this still planned? The ratis-thirdparty-hadoop module was renamed to ratis-thirdparty-misc some time ago. Let me update the doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
