szetszwo commented on a change in pull request #600:
URL: https://github.com/apache/ratis/pull/600#discussion_r805583087
##########
File path:
ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -147,16 +153,16 @@ private void sendRequestToNetwork(DataStreamWindowRequest
request,
scheduleWithTimeout(request);
- requestFuture.thenApply(reply -> {
+ requestFuture.thenApplyAsync(reply -> {
Review comment:
This is only for processing the reply which is simple memory operations
without any IO. Are you sure this would help the performance?
Since we are using Netty, there is already a EventLoopGroup in Netty to do
the send IO; see
https://github.com/apache/ratis/blob/d41d0930c49c4cfcd8cd709519329e22fbbe61b4/ratis-netty/src/main/java/org/apache/ratis/netty/client/NettyClientStreamRpc.java#L247-L259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ratis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
