guohao-rosicky commented on a change in pull request #606:
URL: https://github.com/apache/ratis/pull/606#discussion_r812011898
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -97,9 +97,17 @@ private void getDataStreamOutput(RaftClientRequest request,
Set<RaftPeer> peers,
throws IOException {
for (RaftPeer peer : peers) {
try {
- outs.add((DataStreamOutputRpc)
map.getProxy(peer.getId()).stream(request));
+ DataStreamClient client = map.getProxy(peer.getId());
+ outs.add((DataStreamOutputRpc) client.stream(request));
} catch (IOException e) {
- throw new IOException(map.getName() + ": Failed to
getDataStreamOutput for " + peer, e);
+ map.handleException(peer.getId(), e, false);
+ throw new IOException(
+ map.getName() + ": Failed to getDataStreamOutput for " + peer,
e);
+ } catch (NullPointerException e) {
Review comment:
I agree with that. This PR will also solve other problems. I can open
another JIRA and continue to follow the PROBLEMS of NPE.
What do you think? @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
