adoroszlai commented on a change in pull request #617:
URL: https://github.com/apache/ratis/pull/617#discussion_r818704477
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcClientProtocolService.java
##########
@@ -48,8 +48,8 @@
import java.util.function.Consumer;
import java.util.function.Supplier;
-class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase {
- private static final Logger LOG =
LoggerFactory.getLogger(GrpcClientProtocolService.class);
+public class GrpcClientProtocolService extends
RaftClientProtocolServiceImplBase {
+ public static final Logger LOG =
LoggerFactory.getLogger(GrpcClientProtocolService.class);
Review comment:
I also encountered compile error while trying recent Ratis changes
(RATIS-1515, etc.) with Ozone. But I think exposing `LOG` as public only for
Ozone test is bad practice. We may be able to improve
`TestRatisPipelineLeader` by using custom retry policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
