SincereXIA commented on a change in pull request #616:
URL: https://github.com/apache/ratis/pull/616#discussion_r820013916
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLogWorker.java
##########
@@ -355,7 +356,7 @@ private boolean shouldFlush() {
} else if (pendingFlushNum >= forceSyncNum) {
return true;
}
- return pendingFlushNum > 0 && queue.isEmpty() &&
lastFlush.elapsedTime().compareTo(flushIntervalMin) > 0;
Review comment:
> @SincereXIA , We already have raft.server.log.flush.interval.min . Do
you mean adding another flush interval?
In my test, I found that add flush interval in this way has bug, It will
greatly reduce the submission speed of Raft log. So I had to remove it.
For now, I can't increase the refresh interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
