kaijchen commented on PR #647: URL: https://github.com/apache/ratis/pull/647#issuecomment-1137487310
Hi @Xushaohong, thanks for the proposal. I have a question about it. From ozone's view, if some file in the old checkpoint needs to be purged, doesn't that mean that file is useless? For example, suppose the old checkpoint is `[1, 2, 3]`, and the new checkpoint is `[1, 3, 4]`. Even if the lagging DN successfully pulls file `2` from master and finished the `NotifyInstallSnapshot`. Next iteration of incremental snapshot will pull `4` and delete `2`. So why do we need to keep `2` on master until `NotifyInstallSnapshot` is done? Please correct me if I'm wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
